Consolidate macros between option class types.

Member anonymous_namespace{addr2ln_options.cpp}::fetch_address (char const *text)

The conversion routine does not necessarily map to a full-width pointer, but whatever size integer strtoul returns.

Member anonymous_namespace{pstack.cpp}::output_stack_frame (SymbolEngine &symbol_eng, psystem::module_address_map const &modules, psystem::stack_frame const &frame)

msvc_generated

Source-code line information unimplemented.

Member anonymous_namespace{symbol_file_module.cpp}::print_optional_image_header (T const &hdr, bool const is_dll)

Only for IMAGE_OPTIONAL_HEADER32

globalScope> Member check_debug_symbols (psystem::symbol_view const *sym_view, psystem::address_t const *module_base, psystem::address_t const address)

Remove a bunch of unneeded casts for pointer arithmetic throughout the code.

globalScope> Member DEFINE_DISPATCH_EVENT_FUNC (listener_func, info_type)

We could probably do this with templates.

File demangle.cpp

Replace this with a custom implementation. This version exists to save time, and is so old that it predates anything from C++11 forward.

globalScope> Member get_file_name_from_handle (HANDLE const h_file) noexcept

Merge this with the module_info.cpp version?

globalScope> Member LOAD_FUNCTION (f)

This doesn't update the base class' function pointers!

globalScope> Member main (int const argc, char const *argv[])

/I option (scan file for symbols) not implemented.

/P option (administrative privs) not implemented.

File platform.hpp

Decide on a consistent approach between TCHAR and char...

Remove "_t" from non-system types.

globalScope> Member process_pid (proclib::debug_engine &engine, psystem::process_id_t const pid)

Document what exceptions this throws (there are many).

It would be nice if a problem with on PID didn't stop execution. Rearrange the exception handling a bit.

Debug-only log message here

Namespace proclib

Remove when logging exists

Remove iostream when we have a logging facility.

Member proclib::debug_engine::wait_for_event (DWORD ms=INFINITE) const

No way to determine time-out vs unhandled event

LOG

Class proclib::process_debugger

This doesn't do much right now. Maybe it should automatically add the (currently) pstack::pstack_event_handler and provide access to process_info, etc?

Member proclib::process_debugger::add_event_listener (std::shared_ptr< base_debug_event_listener > const &l)

Deal with double-adds of the same listener

Need a way to generate an ID

Member proclib::process_debugger::remove_event_listener (event_listener_id_t id)

This is not implemented!

Member proclib::process_debugger::~process_debugger ()

Replace this when we have a logging facility.

Class pstack::debug_event_dumper

Make the output stream a CTOR parameter.

Member pstack::debug_event_dumper::exception_event (psystem::process_id_t pid, psystem::thread_id_t tid, EXCEPTION_DEBUG_INFO const &info) noexcept override

There are also extra "parameters" that we're ignoring.

Member pstack::debug_event_dumper::output_debug_string_event (psystem::process_id_t pid, psystem::thread_id_t tid, OUTPUT_DEBUG_STRING_INFO const &info) noexcept override

Read from other process's memory...

Member pstack::pstack_event_handler::create_process_event (psystem::process_id_t pid, psystem::thread_id_t tid, psystem::shared_handle<> const &file_handle, CREATE_PROCESS_DEBUG_INFO const &info) noexcept override

Should we not "share" HANDLE?

Manual module file symbol loading

Member pstack::pstack_event_handler::create_thread_event (psystem::process_id_t pid, psystem::thread_id_t tid, CREATE_THREAD_DEBUG_INFO const &info) noexcept override

Should we not "share" HANDLE?

Member pstack::pstack_event_handler::m_is_debugger_ready

Should this be a state machine to allow us to determine "saw process" -> "saw threads" -> "saw modules" -> etc?

Member pstack::pstack_event_handler::unload_dll_event (psystem::process_id_t pid, psystem::thread_id_t tid, UNLOAD_DLL_DEBUG_INFO const &info) noexcept override

Need to figure out index for some kind of set

Member pstack::pstack_options::get_image_symbols () noexcept

Not using this yet.

Member pstack::pstack_options::options_data::show_debug

UNUSED

Member pstack::pstack_options::try_switch (char arg)

Either throw a better exception type (help_exception) or perhaps alter the flow so that a return value can present the same behavior.

Use administrative privs if possible

File pstack_ns.hpp

It might be nice to be able to selectively use the 32-bit or 64-bit process examination API. Currently, we're held to 64-bit only.

Namespace psystem

Remove iostream when we have a logging facility.

Member psystem::dbghelp_symbol_engine::dbghelp_symbol_engine (HANDLE h_process)

Track process handles and throw an exception if the same one is accessed twice.

This should be an except

In order to not "invade process = TRUE" we need to replace the callbacks in StackWalk.

Custom search path for symbols?

This should be an except

In order to not "invade process = TRUE" we need to replace the callbacks in StackWalk.

Custom search path for symbols?

Member psystem::dbghelp_symbol_engine::find_symbol (address_t address)

Probably don't want to do this on the stack. In fact, since this is single-threaded, we might just allocate a static buffer?

Strange to return an unique_ptr here...

Member psystem::dbghelp_symbol_engine::~dbghelp_symbol_engine ()

Replace this when we have a logging facility.

Class psystem::debug_help_dll

unload() will leave bad function pointers here.

Class psystem::default_close_handle< T >

Examine the return value from CloseHandle().

Member psystem::default_close_handle< T >::close_handle (T hndl) noexcept

Log if the result is not a success.

Class psystem::dll_export_iterator

Beef up this interface! It's really just the minimal set of what I use today.

Hide the public member data – this is a temporary hack for time.

Figure out how this could possibly be a "regular" iterator.

Member psystem::dll_export_iterator::dll_export_iterator (uint8_t const *base_address, integral_address_t const va_offset, uint16_t const index, uint32_t const *export_rva, uint16_t const *idx_with_name, uint32_t const *export_name_rva) noexcept

Add ASSERTions here.

Member psystem::dll_export_view::dll_export_view (uint8_t const *base_address, uint8_t const *load_address, integral_address_t va_offset, uint16_t const *idx_with_name, uint32_t const *export_rva, uint32_t const *export_name_rva, uint32_t number_of_functions, uint32_t number_of_names) noexcept

Might be nicer if only something with a memory-mapped file could create an instance.

A lot of this should be psystem::address_t types instead of *

Member psystem::error_t

Use this in place of DWORD

Class psystem::exception::base_exception

Every exception should support the copy and assignment operations.

Remove not_assignable

Member psystem::exception::base_exception::format_message (char const *msg,...) noexcept

Should this be moved somewhere more global?

Class psystem::exception::system_exception

Make a windows_exception that derives from this; allow errno in a different exception type.

Remove the duplicate m_what members.

Member psystem::exception::system_exception::get_windows_error (DWORD error_code) noexcept

*NIX version of FormatMessage...

Member psystem::exception::system_exception::m_what

Remove me.

Member psystem::exception::system_exception::what () const noexcept override

Remove me

Class psystem::image_symbol_iterator

Some debug runtime bounds checking would be nice.

Member psystem::image_symbol_iterator::~image_symbol_iterator () noexcept

Should "=default" when MSVC sorts out "noexcept".

Member psystem::initialize_psystem ()

Better exception

Member psystem::log_level

Move logging into separate header

Class psystem::module_info

Get module names

Move operations

Pass in needed data to be more platform compatible?

Class psystem::process_info

Should this be movable instead of psystem::not_assignable?

Member psystem::process_info::add_thread (std::unique_ptr< thread_info > thread) noexcept

This will destroy the thread instance if tid already exists!

Member psystem::process_info::m_threads

Wrap this more sensibly w/o exposing unique_ptr.

Member psystem::process_info::remove_thread (thread_id_t tid) noexcept

Perhaps this should return the thread...

Member psystem::process_info::thread_info_map

Make private...

Class psystem::shared_handle< T, kInvalidHandle >

Irritatingly, constexpr is not possible on Windows, which makes the invalid_handle_value member not possible. It would be great to change the instances of kInvalidHandle back to invalid_handle_value when MSVC brings itself up to three years ago.

Member psystem::shared_library::get_version () const

Better exception

Member psystem::shared_library::loaded_function< T, is_void_ref >::loaded_function (FARPROC proc)

I would rather inherit the CTOR with "using base::base", but MSVC apparently does not support this.

Member psystem::shared_library::loaded_function< T, is_void_ref >::operator() (Args &&...args) -> decltype(std::declval< T >()(std::forward< Args >(args)...))

Determine the noexcept value when MSVC supports it.

Member psystem::shared_library::loaded_function< T, std::true_type >::loaded_function (FARPROC proc)

I would rather inherit the CTOR with "using base::base", but MSVC apparently does not support this.

Member psystem::shared_library::loaded_function< T, std::true_type >::operator() (Args &&...args)

Determine the noexcept value when MSVC supports it.

Class psystem::symbol

There should be a function_symbol as well as a plain symbol.

Rename to symbol_info...

Member psystem::symbol::m_code_offset

Move this to a function-specific class.

Member psystem::symbol_file_module::dump_module_info () const

Better exception.

Better exception

Member psystem::symbol_file_module::get_dll_export_view ()

Better exception.

Better exception

Member psystem::symbol_file_module::get_symbol_view ()

Better exception.

Better exception

Member psystem::symbol_file_module::~symbol_file_module () noexcept

Remove noexcept on DTOR

Member psystem::thread_info::generate_stack_trace (HANDLE process_handle, HANDLE thread_handle, address_to_symbol_func address_to_symbol, get_module_base_func get_module_base, std::unique_ptr< stack_trace > *out)

Better way to get this

Member psystem::thread_info::get_stack_trace (process_info const &proc, address_to_symbol_func address_to_symbol, get_module_base_func get_module_base) const

Find a way to get rid of the proc parameter. It's illogical. We are a thread of execution in a process, so why do we need a process passed in? What if they pass a different process? What would that logically even mean??

Member psystem::unique_handle< T, D, kInvalidHandle >::swap (unique_handle &o) noexcept

Better "best practices" to practice for swap?

Class psystem::unique_handle_impl< T, D, kInvalidHandle >

Irritatingly, constexpr is not possible on Windows, which makes the invalid_handle_value member not possible. It would be great to change the instances of kInvalidHandle back to invalid_handle_value when MSVC brings itself up to three years ago.

Maybe we can keep the handle on a block that can be specialized to have/not have a deleter, rather than specializing pretty much the entire unique_handle class.

File shared_library.cpp

Create ImgHelp and DbgHelp subclasses for psystem::shared_library.

Create an init_psystem function to explicitly load the libraries, and check their required versions.

Statically declare the imagehelp and dbghelp instances so they are unloaded regardless of whether they are loaded.

Do we MutEx around load and unload to protect clearing out of m_functions?

Do we load DLLs lazily instead of explicitly? This would require checking the shared_handle every time a function is called. Similarly, do we load functions lazily? Do determine laziness via preproc flag or something?

globalScope> Member utf16_to_tchar (wchar_t const *data)

Move somewhere more global.

globalScope> Member utf8_to_tchar (char const *data)

Move somewhere more global.